Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

Commit 071c147

Browse files
docs: Add clarification on whether NodePool.version is a required field (#344)
* docs: Improve `version` documentation for `NodePool` PiperOrigin-RevId: 506627554 Source-Link: googleapis/googleapis@666a551 Source-Link: https://github.com/googleapis/googleapis-gen/commit/e666add3b7a5b2b9cf21d4f2b70026da361664d9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTY2NmFkZDNiN2E1YjJiOWNmMjFkNGYyYjcwMDI2ZGEzNjE2NjRkOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: Add clarification on whether `NodePool.version` is a required field PiperOrigin-RevId: 506777053 Source-Link: googleapis/googleapis@ffc5ffc Source-Link: https://github.com/googleapis/googleapis-gen/commit/d8776e811018df6944265b06d9b4148783f25759 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDg3NzZlODExMDE4ZGY2OTQ0MjY1YjA2ZDliNDE0ODc4M2YyNTc1OSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 4f4d311 commit 071c147

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

google/cloud/container_v1/types/cluster_service.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -4870,7 +4870,9 @@ class NodePool(proto.Message):
48704870
self_link (str):
48714871
[Output only] Server-defined URL for the resource.
48724872
version (str):
4873-
The version of the Kubernetes of this node.
4873+
The version of Kubernetes running on this NodePool's nodes.
4874+
If unspecified, it defaults as described
4875+
`here <https://cloud.google.com/kubernetes-engine/versioning#specifying_node_version>`__.
48744876
instance_group_urls (MutableSequence[str]):
48754877
[Output only] The resource URLs of the `managed instance
48764878
groups <https://cloud.google.com/compute/docs/instance-groups/creating-groups-of-managed-instances>`__
@@ -5865,7 +5867,7 @@ class AutoprovisioningNodePoolDefaults(proto.Message):
58655867
platform <https://cloud.google.com/compute/docs/instances/specify-min-cpu-platform>`__.
58665868
This field is deprecated, min_cpu_platform should be
58675869
specified using
5868-
https://cloud.google.com/requested-min-cpu-platform label
5870+
``cloud.google.com/requested-min-cpu-platform`` label
58695871
selector on the pod. To unset the min cpu platform field
58705872
pass "automatic" as field value.
58715873
disk_size_gb (int):

google/cloud/container_v1beta1/types/cluster_service.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -5471,7 +5471,9 @@ class NodePool(proto.Message):
54715471
self_link (str):
54725472
[Output only] Server-defined URL for the resource.
54735473
version (str):
5474-
The version of the Kubernetes of this node.
5474+
The version of Kubernetes running on this NodePool's nodes.
5475+
If unspecified, it defaults as described
5476+
`here <https://cloud.google.com/kubernetes-engine/versioning#specifying_node_version>`__.
54755477
instance_group_urls (MutableSequence[str]):
54765478
[Output only] The resource URLs of the `managed instance
54775479
groups <https://cloud.google.com/compute/docs/instance-groups/creating-groups-of-managed-instances>`__
@@ -6448,7 +6450,7 @@ class AutoprovisioningNodePoolDefaults(proto.Message):
64486450
platform <https://cloud.google.com/compute/docs/instances/specify-min-cpu-platform>`__.
64496451
This field is deprecated, min_cpu_platform should be
64506452
specified using
6451-
https://cloud.google.com/requested-min-cpu-platform label
6453+
``cloud.google.com/requested-min-cpu-platform`` label
64526454
selector on the pod. To unset the min cpu platform field
64536455
pass "automatic" as field value.
64546456
disk_size_gb (int):

samples/generated_samples/snippet_metadata_google.container.v1.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
],
99
"language": "PYTHON",
1010
"name": "google-cloud-container",
11-
"version": "2.17.2"
11+
"version": "0.1.0"
1212
},
1313
"snippets": [
1414
{

samples/generated_samples/snippet_metadata_google.container.v1beta1.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
],
99
"language": "PYTHON",
1010
"name": "google-cloud-container",
11-
"version": "2.17.2"
11+
"version": "0.1.0"
1212
},
1313
"snippets": [
1414
{

0 commit comments

Comments
 (0)