This repository was archived by the owner on Dec 17, 2023. It is now read-only.
chore: update sync-repo-settings #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add GH Action checks, remove Kokoro, and update required versions of samples.
| - 'docs', | ||
| - 'docfx', | ||
| - 'lint', | ||
| - 'unit (3.6)', |
There was a problem hiding this comment.
Do we want to have consistency on 3.6 between unit tests and sample tests? I don't see 3.6 listed under samples.
There was a problem hiding this comment.
@kweinmeister We (Python samples folks) have mostly dropped Python 3.6 from the samples testing matrix as it went EOL in December 2021. It remains in the library unit test matrix since the library states it is compatible in the setup.py.
Historically we've stopped testing samples against a particular version a bit earlier than we stop testing the library.
parthea
approved these changes
Feb 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GH Action checks, remove Kokoro, and update required versions of samples.