Skip to content
This repository was archived by the owner on Jul 6, 2023. It is now read-only.

Commit 259f1c9

Browse files
docs: mark CaPool.lifetime as IMMUTABLE (#177)
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 425978220 Source-Link: googleapis/googleapis@16ce675 Source-Link: https://github.com/googleapis/googleapis-gen/commit/ca0915494a7708d04c137058c4eafe65816a1e7b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2EwOTE1NDk0YTc3MDhkMDRjMTM3MDU4YzRlYWZlNjU4MTZhMWU3YiJ9 docs: add format requirements on `custom_sans`
1 parent d63e401 commit 259f1c9

File tree

3 files changed

+19
-18
lines changed

3 files changed

+19
-18
lines changed

google/cloud/security/privateca_v1/types/resources.py

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,9 @@ class CertificateAuthority(proto.Message):
103103
Required. Immutable. The config used to
104104
create a self-signed X.509 certificate or CSR.
105105
lifetime (google.protobuf.duration_pb2.Duration):
106-
Required. The desired lifetime of the CA certificate. Used
107-
to create the "not_before_time" and "not_after_time" fields
108-
inside an X.509 certificate.
106+
Required. Immutable. The desired lifetime of the CA
107+
certificate. Used to create the "not_before_time" and
108+
"not_after_time" fields inside an X.509 certificate.
109109
key_spec (google.cloud.security.privateca_v1.types.CertificateAuthority.KeyVersionSpec):
110110
Required. Immutable. Used when issuing certificates for this
111111
[CertificateAuthority][google.cloud.security.privateca.v1.CertificateAuthority].
@@ -212,7 +212,7 @@ class SignHashAlgorithm(proto.Enum):
212212
[CryptoKeyVersionAlgorithm][google.cloud.kms.v1.CryptoKeyVersion.CryptoKeyVersionAlgorithm]
213213
values. For RSA signing algorithms, the PSS algorithms should be
214214
preferred, use PKCS1 algorithms if required for compatibility. For
215-
further recommandations, see
215+
further recommendations, see
216216
https://cloud.google.com/kms/docs/algorithms#algorithm_recommendations.
217217
"""
218218
SIGN_HASH_ALGORITHM_UNSPECIFIED = 0
@@ -502,14 +502,14 @@ class RsaKeyType(proto.Message):
502502
Attributes:
503503
min_modulus_size (int):
504504
Optional. The minimum allowed RSA modulus
505-
size, in bits. If this is not set, or if set to
506-
zero, the service-level min RSA modulus size
507-
will continue to apply.
505+
size (inclusive), in bits. If this is not set,
506+
or if set to zero, the service-level min RSA
507+
modulus size will continue to apply.
508508
max_modulus_size (int):
509509
Optional. The maximum allowed RSA modulus
510-
size, in bits. If this is not set, or if set to
511-
zero, the service will not enforce an explicit
512-
upper bound on RSA modulus sizes.
510+
size (inclusive), in bits. If this is not set,
511+
or if set to zero, the service will not enforce
512+
an explicit upper bound on RSA modulus sizes.
513513
"""
514514

515515
min_modulus_size = proto.Field(proto.INT64, number=1,)
@@ -987,7 +987,7 @@ class SubordinateConfig(proto.Message):
987987
certificate_authority (str):
988988
Required. This can refer to a
989989
[CertificateAuthority][google.cloud.security.privateca.v1.CertificateAuthority]
990-
in the same project that was used to create a subordinate
990+
that was used to create a subordinate
991991
[CertificateAuthority][google.cloud.security.privateca.v1.CertificateAuthority].
992992
This field is used for information and usability purposes
993993
only. The resource name is in the format
@@ -1410,8 +1410,9 @@ class SubjectAltNames(proto.Message):
14101410
Contains only valid 32-bit IPv4 addresses or
14111411
RFC 4291 IPv6 addresses.
14121412
custom_sans (Sequence[google.cloud.security.privateca_v1.types.X509Extension]):
1413-
Contains additional subject alternative name
1414-
values.
1413+
Contains additional subject alternative name values. For
1414+
each custom_san, the ``value`` field must contain an ASN.1
1415+
encoded UTF8String.
14151416
"""
14161417

14171418
dns_names = proto.RepeatedField(proto.STRING, number=1,)

google/cloud/security/privateca_v1/types/service.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -95,11 +95,11 @@ class CreateCertificateRequest(proto.Message):
9595
minutes since the first request.
9696
9797
For example, consider a situation where you make
98-
an initial request and t he request times out.
99-
If you make the request again with the same
100-
request ID, the server can check if original
101-
operation with the same request ID was received,
102-
and if so, will ignore the second request. This
98+
an initial request and the request times out. If
99+
you make the request again with the same request
100+
ID, the server can check if original operation
101+
with the same request ID was received, and if
102+
so, will ignore the second request. This
103103
prevents clients from accidentally creating
104104
duplicate commitments.
105105
The request ID must be a valid UUID with the

security-privateca-v1-py.tar.gz

Whitespace-only changes.

0 commit comments

Comments
 (0)