Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

docs(samples): added mute config samples #276

Merged
merged 31 commits into from
Mar 25, 2022
Merged

docs(samples): added mute config samples #276

merged 31 commits into from
Mar 25, 2022

Conversation

Sita04
Copy link
Contributor

@Sita04 Sita04 commented Feb 1, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@snippet-bot
Copy link

snippet-bot bot commented Feb 1, 2022

Here is the summary of changes.

You are about to add 7 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: securitycenter Issues related to the googleapis/python-securitycenter API. samples Issues that are directly related to samples. labels Feb 1, 2022
@Sita04 Sita04 changed the title Mute config samples docs(samples): added Mute config samples Feb 1, 2022
@Sita04 Sita04 added the blunderbuss: assign Instruct blunderbuss to assign someone label Feb 1, 2022
@Sita04 Sita04 requested a review from a team as a code owner February 1, 2022 12:50
@catherinerosesantos
Copy link

catherinerosesantos commented Feb 1, 2022

Looks good! Just a few minor changes. Thanks!

@Sita04
Copy link
Contributor Author

Sita04 commented Feb 2, 2022

Looks good! Just a few minor changes. Thanks!

Thanks for the review, Catherine! I've applied the suggestions. PTAL.

@Sita04 Sita04 added blunderbuss: assign Instruct blunderbuss to assign someone kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed blunderbuss: assign Instruct blunderbuss to assign someone labels Feb 2, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2022
@kurtisvg kurtisvg changed the title docs(samples): added Mute config samples chore(samples): added mute config samples Feb 2, 2022
@kurtisvg kurtisvg requested review from a team and removed request for a team February 2, 2022 22:02
parthea
parthea previously approved these changes Feb 26, 2022
@parthea parthea dismissed their stale review February 26, 2022 18:54

Tests are failing with InvalidArgument: 400 Request contains an invalid argument.

@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 15, 2022
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2022
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2022
@Sita04 Sita04 requested a review from parthea March 25, 2022 21:48
@parthea parthea merged commit 3ac8eac into main Mar 25, 2022
@parthea parthea deleted the mute-config-samples branch March 25, 2022 22:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: securitycenter Issues related to the googleapis/python-securitycenter API. blunderbuss: assign Instruct blunderbuss to assign someone samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants