Skip to content

feat: add FLOAT32 enum to TypeCode #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 28, 2024
Merged

feat: add FLOAT32 enum to TypeCode #1081

merged 5 commits into from
Jan 28, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jan 24, 2024

BEGIN_COMMIT_OVERRIDE
feat: add FLOAT32 enum to TypeCode
feat: add proto descriptors for proto and enum types in create/update/get database ddl requests
END_COMMIT_OVERRIDE

  • Regenerate this pull request now.

PiperOrigin-RevId: 601176446

Source-Link: googleapis/googleapis@584ecd4

Source-Link: https://github.com/googleapis/googleapis-gen/commit/0bdb815779d0fd7824bafff0c91046a7dca5cd5f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGJkYjgxNTc3OWQwZmQ3ODI0YmFmZmYwYzkxMDQ2YTdkY2E1Y2Q1ZiJ9

BEGIN_NESTED_COMMIT
feat(spanner): add proto descriptors for proto and enum types in create/update/get database ddl requests
PiperOrigin-RevId: 601013501

Source-Link: googleapis/googleapis@81b24a5

Source-Link: https://github.com/googleapis/googleapis-gen/commit/46f0446037906f0d905365835f02a652241f3de3
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZmMDQ0NjAzNzkwNmYwZDkwNTM2NTgzNWYwMmE2NTIyNDFmM2RlMyJ9
END_NESTED_COMMIT

…te/update/get database ddl requests

PiperOrigin-RevId: 601013501

Source-Link: googleapis/googleapis@81b24a5

Source-Link: googleapis/googleapis-gen@46f0446
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZmMDQ0NjAzNzkwNmYwZDkwNTM2NTgzNWYwMmE2NTIyNDFmM2RlMyJ9
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 24, 2024
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Jan 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 24, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Jan 24, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 24, 2024
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review January 24, 2024 08:54
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners January 24, 2024 08:54
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Jan 24, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 24, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 24, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 24, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 24, 2024
PiperOrigin-RevId: 601176446

Source-Link: googleapis/googleapis@584ecd4

Source-Link: googleapis/googleapis-gen@0bdb815
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGJkYjgxNTc3OWQwZmQ3ODI0YmFmZmYwYzkxMDQ2YTdkY2E1Y2Q1ZiJ9
@gcf-owl-bot gcf-owl-bot bot changed the title feat(spanner): add proto descriptors for proto and enum types in create/update/get database ddl requests feat: add FLOAT32 enum to TypeCode Jan 24, 2024
Copy link

snippet-bot bot commented Jan 24, 2024

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 24, 2024
@product-auto-label product-auto-label bot removed the size: m Pull request size is medium. label Jan 24, 2024
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Jan 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 24, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 24, 2024
@product-auto-label product-auto-label bot removed the size: xl Pull request size is extra large. label Jan 24, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 24, 2024
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 24, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 24, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 24, 2024
@harshachinta harshachinta merged commit 5b94dac into main Jan 28, 2024
@harshachinta harshachinta deleted the owl-bot-copy branch January 28, 2024 05:27
Copy link
Contributor Author

gcf-owl-bot bot commented Jan 28, 2024

Owl bot is regenerating pull request 1081...
Build name: MzY2ZjUxN2QtMmU3YS00NTQyLWE3ZjYtZTE0YzgwMmE0ODU3

@harshachinta
Copy link
Contributor

harshachinta commented Jan 28, 2024

@parthea
Kokoro builds are failing after merging this autogenerated PR.
https://fusion2.corp.google.com/ci/kokoro/prod:cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-spanner%2Fpresubmit%2Fpresubmit/activity/734a4ca6-aa1b-4412-aba7-9adf2a81e74f/log

But from the error as shown below, it looks like the issue is with pytest_asyncio. I don't think the issue is because of this PR. But do you know what is the reason of this failure?

nox > Session unit-3.9 failed.
nox > Running session unit-3.10
nox > Creating virtual environment (virtualenv) using python3.10 in .nox/unit-3-10
nox > python -m pip install mock asyncmock pytest pytest-cov pytest-asyncio -c /tmpfs/src/github/python-spanner/testing/constraints-3.10.txt
nox > python -m pip install -e . -c /tmpfs/src/github/python-spanner/testing/constraints-3.10.txt
nox > py.test --quiet --junitxml=unit_3.10_sponge_log.xml --cov=google --cov=tests/unit --cov-append --cov-config=.coveragerc --cov-report= --cov-fail-under=0 tests/unit
/[tmpfs/src/github/python-spanner/.nox/unit-3-10/lib/python3.10/site-packages/coverage/control.py:887](https://cs.corp.google.com/piper///depot/google3/tmpfs/src/github/python-spanner/.nox/unit-3-10/lib/python3.10/site-packages/coverage/control.py?l=887): CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")

==================================== ERRORS ====================================
________________________ ERROR collecting test session _________________________
[.nox/unit-3-10/lib/python3.10/site-packages/pluggy/_hooks.py:501](https://cs.corp.google.com/piper///depot/google3/.nox/unit-3-10/lib/python3.10/site-packages/pluggy/_hooks.py?l=501): in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
[.nox/unit-3-10/lib/python3.10/site-packages/pluggy/_manager.py:119](https://cs.corp.google.com/piper///depot/google3/.nox/unit-3-10/lib/python3.10/site-packages/pluggy/_manager.py?l=119): in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
[.nox/unit-3-10/lib/python3.10/site-packages/pytest_asyncio/plugin.py:626](https://cs.corp.google.com/piper///depot/google3/.nox/unit-3-10/lib/python3.10/site-packages/pytest_asyncio/plugin.py?l=626): in pytest_collectstart
    pyobject = collector.obj
E   AttributeError: 'Package' object has no attribute 'obj'
- generated xml file: /tmpfs/src/github/python-spanner/unit_3.10_sponge_log.xml -
=========================== short test summary info ============================
ERROR  - AttributeError: 'Package' object has no attribute 'obj'
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
1 error in 0.22s

@harshachinta
Copy link
Contributor

@parthea Kokoro builds are failing after merging this autogenerated PR. https://fusion2.corp.google.com/ci/kokoro/prod:cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-spanner%2Fpresubmit%2Fpresubmit/activity/734a4ca6-aa1b-4412-aba7-9adf2a81e74f/log

But from the error as shown below, it looks like the issue is with pytest_asyncio. I don't think the issue is because of this PR. But do you know what is the reason of this failure?

nox > Session unit-3.9 failed.
nox > Running session unit-3.10
nox > Creating virtual environment (virtualenv) using python3.10 in .nox/unit-3-10
nox > python -m pip install mock asyncmock pytest pytest-cov pytest-asyncio -c /tmpfs/src/github/python-spanner/testing/constraints-3.10.txt
nox > python -m pip install -e . -c /tmpfs/src/github/python-spanner/testing/constraints-3.10.txt
nox > py.test --quiet --junitxml=unit_3.10_sponge_log.xml --cov=google --cov=tests/unit --cov-append --cov-config=.coveragerc --cov-report= --cov-fail-under=0 tests/unit
/[tmpfs/src/github/python-spanner/.nox/unit-3-10/lib/python3.10/site-packages/coverage/control.py:887](https://cs.corp.google.com/piper///depot/google3/tmpfs/src/github/python-spanner/.nox/unit-3-10/lib/python3.10/site-packages/coverage/control.py?l=887): CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")

==================================== ERRORS ====================================
________________________ ERROR collecting test session _________________________
[.nox/unit-3-10/lib/python3.10/site-packages/pluggy/_hooks.py:501](https://cs.corp.google.com/piper///depot/google3/.nox/unit-3-10/lib/python3.10/site-packages/pluggy/_hooks.py?l=501): in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
[.nox/unit-3-10/lib/python3.10/site-packages/pluggy/_manager.py:119](https://cs.corp.google.com/piper///depot/google3/.nox/unit-3-10/lib/python3.10/site-packages/pluggy/_manager.py?l=119): in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
[.nox/unit-3-10/lib/python3.10/site-packages/pytest_asyncio/plugin.py:626](https://cs.corp.google.com/piper///depot/google3/.nox/unit-3-10/lib/python3.10/site-packages/pytest_asyncio/plugin.py?l=626): in pytest_collectstart
    pyobject = collector.obj
E   AttributeError: 'Package' object has no attribute 'obj'
- generated xml file: /tmpfs/src/github/python-spanner/unit_3.10_sponge_log.xml -
=========================== short test summary info ============================
ERROR  - AttributeError: 'Package' object has no attribute 'obj'
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
1 error in 0.22s

@parthea
This is fixed now. Please ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. owl-bot-copy size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants