Skip to content

chore: update templated files #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 8, 2024
Merged

chore: update templated files #1156

merged 6 commits into from
Jul 8, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jul 5, 2024 •
edited
Loading

  • Use the latest version of the post processor which includes updates to the release script dependencies as well as testing for all protobuf implementations

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2024
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 5, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Jul 5, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Jul 5, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jul 5, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2024
@parthea parthea marked this pull request as ready for review July 5, 2024 17:13
@parthea parthea requested review from a team as code owners July 5, 2024 17:13
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2024
@parthea parthea mentioned this pull request Jul 8, 2024
Open
@parthea parthea assigned harshachinta and unassigned rajatbhatta Jul 8, 2024
harshachinta
harshachinta reviewed Jul 8, 2024
View reviewed changes
noxfile.py
@nox.session(python=UNIT_TEST_PYTHON_VERSIONS)
@nox.parametrize(
"protobuf_implementation",
["python", "upb", "cpp"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parthea Just curious to understand what does this protobuf_implementation mean and why do we have 3 options ["python", "upb", "cpp"]?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a feature of protobuf where they offer three separate implementations of the Python Protobuf API. There is an expectation that we should support all 3 implementations in the Cloud Python SDK.

upb and python are actively supported in the latest Protobuf 5.x while cpp is only available in Protobuf 3.x

@harshachinta
Copy link
Contributor

harshachinta commented Jul 8, 2024 •
edited
Loading

@parthea

  1. Can you please help add PR description for this change so that it will help understand for someone looking at this change.
  2. Also what changes will get affected with this?

@parthea
Copy link
Contributor Author

parthea commented Jul 8, 2024 •
edited
Loading

Can you please help add PR description for this change so that it will help understand for someone looking at this change.

Done

Also what changes will get affected with this?

This only touches the release script dependencies and updates testing to include all protobuf implementation backends. There are no user facing changes.

@parthea parthea merged commit d00e966 into main Jul 8, 2024
14 of 16 checks passed
@parthea parthea deleted the parthea-patch-2 branch July 8, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshachinta harshachinta harshachinta approved these changes

Assignees

@harshachinta harshachinta

Labels
api: spanner Issues related to the googleapis/python-spanner API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parthea @harshachinta @rajatbhatta