fix: correct notification error message (#1290)

tritone · web-flow · commit 1cb977daa2d9 · 2024-06-17T16:28:04.000-04:00
To create a new notification, the notification_id field must be set to None. Update the error message to clarify this. Fixes #1289
diff --git a/google/cloud/storage/notification.py b/google/cloud/storage/notification.py
@@ -255,7 +255,7 @@ def create(self, client=None, timeout=_DEFAULT_TIMEOUT, retry=None):
         """
         if self.notification_id is not None:
             raise ValueError(
-                f"Notification already exists w/ id: {self.notification_id}"
+                f"notification_id already set to {self.notification_id}; must be None to create a Notification."
             )
 
         client = self._require_client(client)

Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,7 @@ def create(self, client=None, timeout=_DEFAULT_TIMEOUT, retry=None):`
`255`	`255`	`"""`
`256`	`256`	`if self.notification_id is not None:`
`257`	`257`	`raise ValueError(`
`258`		`- f"Notification already exists w/ id: {self.notification_id}"`
	`258`	`+ f"notification_id already set to {self.notification_id}; must be None to create a Notification."`
`259`	`259`	`)`
`260`	`260`
`261`	`261`	`client = self._require_client(client)`