-
Notifications
You must be signed in to change notification settings - Fork 158
feat: Retry by default for uploads, blob deletes, metadata updates #1400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for enabling retry by default woohoo
020c0fe
to
1a5f382
Compare
PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
@andrewsg I've noticed that other SDKs (at least Node.js and Go) seem to apply retries only to idempotent operations, as was previously the case in Python. If you don't mind, could you share a bit of insight into the rationale behind this change? |
@ishowta The C++ library currently has enabled retries by default on these operations. We are changing our policy around these specific operations to match the C++ library's precedent, starting with Python, but assuming there are no issues, later to include the other languages. We've determined that the potential negative effect of a double request for these listed operations is practically nil and the actual negative effect of having retries off by default is very large, as most people don't use generations or if_generation_match. However, if you do experience an unexpected issue with this change, please do let us know about it. |
Thank you for the explanation! In some of our projects, we've been configuring the Cloud Storage SDK to always retry, so I'll use this as a reference. |
No description provided.