test: harden pytest fixture setup stage #1323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielduhh
approved these changes
Jul 9, 2024
andrewsg
reviewed
Jul 9, 2024
| @@ -104,7 +105,11 @@ def shared_bucket_name(): | |||
| def shared_bucket(storage_client, shared_bucket_name): | |||
| bucket = storage_client.bucket(shared_bucket_name) | |||
| bucket.versioning_enabled = True | |||
| _helpers.retry_429_503(bucket.create)() | |||
| # Create the bucket only if it doesn't yet exist. | |||
There was a problem hiding this comment.
Under what circumstances would the bucket already exist? Do we know?
There was a problem hiding this comment.
The flaky test logs returned a 409 conflict error where a fixture bucket already existed. I'm guessing a server connection reset may have happened midway, causing the pytest fixture to rerun, and hence hitting the conflict error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1316
Fixes #1315
Fixes #1314
Fixes #1312
Fixes #1310
Fixes #1300