Skip to content

refactor: replace deprecated method calls for new client methods #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2021
Merged

refactor: replace deprecated method calls for new client methods #347

merged 1 commit into from
Jan 5, 2021

Conversation

HemangChothani
Copy link
Contributor

Fixes #346

@HemangChothani HemangChothani requested review from tseaver, andrewsg and a team December 17, 2020 13:08
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Dec 17, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2020
@frankyn frankyn changed the title refactor: remove deprecated method calls refactor: replace deprecated method calls for new client methods Jan 5, 2021
frankyn
frankyn approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me. @andrewsg do you have any concerns?

andrewsg
andrewsg approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrewsg andrewsg merged commit 6d5a667 into googleapis:master Jan 5, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @cojenco
refactor: remove deprecated method calls (googleapis#347)
9983487
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @cojenco
refactor: remove deprecated method calls (googleapis#347)
556cf78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

@frankyn frankyn frankyn approved these changes

@tseaver tseaver Awaiting requested review from tseaver

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change deprecated method calls
3 participants
@HemangChothani @andrewsg @frankyn