refactor: add / use 'Client._post_resource' method #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2021
Also, add retry support to 'Client.create_hmac_key'. Toward #38.
Also, add retry support to 'BucketNotfication.create'. Toward #38.
Also, avoid making API requests in tests for 'Blob.update_storage_class': mock the blob's 'rewrite' method instead. Toward #38.
Also, avoid making API requests in tests for 'Bucket.rename_blob': mock the bucket's 'copy_blob' method instead. Toward #38.
2acfb06 to
24fdae5
Compare
andrewsg
requested changes
Jun 7, 2021
Per review comment.
Per review comment.
Per review comment.
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #38.
Note: this PR is based on 6244df0 of PR #442. I will rebase to master when that PR lands.Done.