tests: speed up retry conformance tests #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cojenco
commented
Nov 19, 2021
- Speed up retry conf tests to run in parallel with pytest plugin
- Update readme file
tseaver
reviewed
Nov 23, 2021
noxfile.py
Outdated
| session.run("py.test", "--quiet", conformance_test_path, *session.posargs) | ||
| session.run( | ||
| "py.test", "-n", "auto", "--quiet", conformance_test_path, *session.posargs | ||
| ) |
There was a problem hiding this comment.
I think it might be a better DX to inject the "-n", "auto" into the command line only if session.posargs is empty: that way, the user could chose to e.g. restrict the number of cores available, or even distribute the tests across multiple hosts.
There was a problem hiding this comment.
@tseaver good idea! I've updated the noxfile. PTAL, thanks!
tseaver
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.