-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
-relax cabal upper bound constraints -use Control.Monad.Catch (catch,finally) where appropriate as per deprecation warning
@@ -80,10 +81,11 @@ type CallId = MonitorRef | |||
|
|||
newtype CallRef a = CallRef { unCaller :: (Recipient, CallId) } | |||
deriving (Eq, Show, Typeable, Generic) | |||
instance Serializable a => Binary (CallRef a) where | |||
instance NFData a => NFData (CallRef a) where rnf (CallRef x) = rnf x `seq` () | |||
--instance Serializable a => Binary (CallRef a) where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GHC 8 introduces warnings for unnecessary constraints. I should have left this chunk out of the pull request since it is non-essential, but please be aware that the GHC 8 generates a lot of new warnings for this project.
Thanks for the patch! Travis CI is failing but so it did for previous versions and master so I'm merging this. |
The build seems to fail when compiling distributed-process-extras.
I'll try and dig in to this, I'm assuming it's an API having changed somewhere. |
All of those functions are in the Prelude and I don't see any imports hiding them or excluding Prelude. Also, I just pulled from this master and am unable to reproduce this with 8.0.1. Are there any errors above this? |
It seems to be talking to build d-p-extras. I'm gonna look at modifying the extension library builds to emulate distributed-process' since that has changed to use stack and I think these libs should do the same for travis. I'll tweak and submit a pr |
Those functions are from older pre-7.10 GHC where where they were not re-exported by Prelude.
should work for all ghc versions. |
Shows how long I've been awol! Will update in a branch and see if travis is happy... |
Ran "cabal test" against GHC 7.10.3 and GHC 8.0.1 successfully.
I need to compile against binary, time, and deepseq from GHC 8 because our project links against GHC for its scripting engine.
The only remaining warnings in GHC8 are loads of redundant constraint warnings (new in GHC 8), but that will be fixed in a subsequent pull request, if it makes sense to fix them.