Skip to content

Add generic function catMaybes #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Conversation

carlosdagos
Copy link
Contributor

Add catMaybes which provides same function as the one found in Data.Maybe.

I thought this would be a useful function to have. Unfortunately the tests give me a type error when I added the property (in all honesty I don't understand the VectorContext constraint right now). But I thought that I'd hear thoughts about adding this before dedicating more time to it.

Thanks!

@lehins
Copy link
Contributor

lehins commented Aug 28, 2020

The only module where catMaybes is valid is Data.Vector, so feel free to remove it from other modules, including Data.Vector.Generic. Reason for this is very simple, there are no instances of Prim, Unbox or Storable for Maybe a

Add `catMaybes` which provides same function as the one found in
`Data.Maybe`.
@carlosdagos
Copy link
Contributor Author

Done @lehins. Thanks. I actually left the modification to =Data.Vector.Fusion.Stream.Monadic as I think it could be useful there. But I am happy to amend that if need be as well. Cheers.

@lehins lehins merged commit 1758b57 into haskell:master Sep 2, 2020
@lehins lehins mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants