Disable problematic tests with -boundschecks #407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some negative tests (namely, the
testsSliceOutOfBounds
ones in the test groupslice out of bounds #257
) crash the test suitesvector-tests-O0
andvector-tests-O2
when running it without bounds checks. I usedcabal test -f -boundschecks
from inside thevector
directory, but encountered this problem in anix-build
of our project first where I disabled said flag for version0.12.3.0
of the library.It feels like they should not be run at all without those checks.
If there is a better/alternative way to tackle and fix this problem, please let me know and I'll try to update this PR with it :)