Skip to content

Commit bacded5

Browse files
authored
fix(react): intellisense works with IntelliJ (#29782)
Issue number: resolves #29755 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Types do not generate when a React app is opened in IntelliJ IDE. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Updated `stencil/react-output-target` to the latest - Updated the stencil config file - Updated `jest`, `ts-jest`, and `typescript` because of the changes in `packages/react/tsconfig.json` - Installed `jest-environment-jsdom` because Jest 26 no longer ships it by default since the test environment is now node by default. The test environment needs to be changed to `jsdom` when [building a web app](https://jestjs.io/docs/configuration#testenvironment-string). ![Screenshot 2024-08-19 at 3 44 56 PM](https://github.com/user-attachments/assets/7a5ab4e7-4641-4fa7-978d-8f68a0b334ea) ![Screenshot 2024-08-19 at 3 45 11 PM](https://github.com/user-attachments/assets/66f5a522-776b-488d-932f-4fa59cf5dd49) ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> No visual changes are introduced and there will be no changes needed by developers. Their apps will continue to work as is. ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: 8.2.8-dev.11724100788.103018f2
1 parent bf7f6f6 commit bacded5

11 files changed

+4791
-5056
lines changed

core/package-lock.json

+221-15
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
"@rollup/plugin-node-resolve": "^8.4.0",
4949
"@rollup/plugin-virtual": "^2.0.3",
5050
"@stencil/angular-output-target": "^0.8.4",
51-
"@stencil/react-output-target": "^0.5.3",
51+
"@stencil/react-output-target": "^0.6.0",
5252
"@stencil/sass": "^3.0.9",
5353
"@stencil/vue-output-target": "^0.8.9",
5454
"@types/jest": "^29.5.6",

0 commit comments

Comments
 (0)