-
-
Notifications
You must be signed in to change notification settings - Fork 39
Closed
Labels
Milestone
Description
Current naming is not perfect and not consistent. At the beginning I tried to give names according to toml specification. But now I see that it's better to be closer to Haskell. Which brings to the following naming convention:
- Constructors of
Value
andValueType
changes toInteger
,Text
,Double
fromInt
,String
,Float
. And renameValueType
toTValue
. - Each parser should have
P
suffix. - Each prism should be capitalised and start with underscore.
- Each bidirectional converter should be name of constructor without any suffices. When name clashes with
Prelude
name it should haveT
suffix (convention for allBiToml
configurations).
Also, I want to change module structure a bit to make it more modular:
Split Toml.Types
module into Toml.Types.Value
, Toml.Types.AnyValue
, Toml.Types.TOML
, TOML.Types.UValue
. This change is also motivated by fact that Toml.Types
module becomes very big.
Let me know, what do you think!
vrom911