-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Task Page for Verifying Signed Images #32184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task Page for Verifying Signed Images #32184
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
Fixes #31420 |
fed4e4b
to
748af80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits. PTAL 😊
content/en/docs/tasks/administer-cluster/verify-signed-images.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/administer-cluster/verify-signed-images.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/administer-cluster/verify-signed-images.md
Outdated
Show resolved
Hide resolved
f7fd5e8
to
e1d1f29
Compare
@saschagrunert @jihoon-seo updated as per your feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for working on this @PushkarJ!
LGTM label has been added. Git tree hash: 5e19f3a9de514ef0f36d65f316ed3ce1e22ee44e
|
I think the MVP issue documents the scope is restricted to images only. Will let @saschagrunert chime in on if this would be useful to document as current limitation. @sftim I have also addressed all the rest of the comments. |
From a docs point of view, it's useful to let people know what things aren't covered. When we explain that, we try to avoid statements about the future. Phrasing like
for example (using |
Signed-off-by: Sascha Grunert <[email protected]>
Updates based on PR review Apply suggestions from code review Co-authored-by: Tim Bannister <[email protected]>
Apply suggestions from code review Co-authored-by: Qiming Teng <[email protected]> Co-authored-by: Chris Negus <[email protected]>
6b5c560
to
a93833c
Compare
Updated the download.md file with the text suggested by @sftim |
Hello, this is a friendly reminder from the 1.24 docs release team that the Docs’ complete deadline — All PRs reviewed and ready to merge — is EOD Tuesday, April 12th, 2022. Please finish up any remaining technical reviews and edits, and reach out if you need any help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 9abcb47d41c4749f5556ee2f848efaa1f8e34984
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nate-double-u, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sftim can we lift the hold? |
/unhold |
@PushkarJ did you try this out with the beta release? How did it go? |
@@ -3,6 +3,8 @@ title: Download Kubernetes | |||
type: docs | |||
--- | |||
|
|||
# Core Kubernetes components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't have merged this - level 1 headings aren't allowed in our Markdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up in #32895
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I saw #32896
As per kubernetes#32184 (comment), level 1 headers are not allowed in the website markdown. Means we now increase the level by 1. Signed-off-by: Sascha Grunert <[email protected]>
I did not get a chance to test it before this was unheld and merged, since rc.0 is going to be first release with signed images ETA April 19 :( Either way seems unlikely we may need major overhaul of the script or guide. |
@sftim just confirmed that the shell script works, but I think adding |
Supersedes #31611
In support of kubernetes/release#2383
Relevant KEP: kubernetes/enhancements#3031
/sig security release docs
Notes:
/cc @saschagrunert @puerco @sftim