Practical Redux Part 4 - WIP commits #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated App CSS to only center header, instead of everything. This keeps the tab contents from centering as well.
There's been numerous requests for Create-React-App to support having imports resolved relative to the "src" folder. The semi-documented solution is to have a NODE_PATH environment variable, which will be used in the resolution process. It's apparently also possible to specify that variable in a file named ".env". References: facebook/create-react-app#476 facebook/create-react-app#693 facebook/create-react-app#741
Moved TabBar to common/components Added reducer utility functions Added tab handling logic Added TabContainer Added tabs reducer to root reducer Removed dead test reducer Changed TabBar to be a functional component, since it's now stateless
I was previously on 0.60.9. Unfortunately, that apparently had a huge performance issue, due to the way Lodash was being used to omit props that components didn't handle themselves. That resulted in increasingly slow performance to switch tabs as I added more components per tab panel (and not that many components, either!). The perf issue was fixed in 0.60.10, naturally. References: Semantic-Org/Semantic-UI-React#860 Semantic-Org/Semantic-UI-React#864
Removed unused component imports Added keys to tabs and tab panels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original WIP commits for the progress described in Practical Redux Part 4: UI Layout and Project Structure.