Skip to content

RUST-1757 Fix final cursor batch handling #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

abr-egn
Copy link
Contributor

@abr-egn abr-egn commented Sep 6, 2023

RUST-1757

Looks like this broke as part of a refactor a few weeks ago, so the only release it's live in is 2.7.0-beta :)

Copy link
Contributor

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! this seems like something we should have test coverage of outside of the benchmarks, would you mind adding a repro of what broke so it doesn't happen again?

@abr-egn
Copy link
Contributor Author

abr-egn commented Sep 13, 2023

good catch! this seems like something we should have test coverage of outside of the benchmarks, would you mind adding a repro of what broke so it doesn't happen again?

Added a test :) Was a little harder to poke this behavior than I thought until I realized that advance and the Stream impl don't share logic here - I think this is also why this didn't break any spec tests, as those all use Stream methods. I filed RUST-1761 to merge these.

@abr-egn abr-egn merged commit 85de932 into mongodb:main Sep 15, 2023
abr-egn added a commit to abr-egn/mongo-rust-driver that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants