Skip to content

Commit eb89c06

Browse files
bnoordhuistargos
authored andcommitted
build: fix icu-i18n pkg-config version check
The pkg_config() helper can either return a tuple of None values (no pkg-config installed) and that was what the check was testing for, but it can also return a tuple of empty strings when the package isn't installed. PR-URL: #28118 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 02fdf5c commit eb89c06

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

configure.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1348,7 +1348,7 @@ def write_config(data, name):
13481348
# ICU from pkg-config.
13491349
o['variables']['v8_enable_i18n_support'] = 1
13501350
pkgicu = pkg_config('icu-i18n')
1351-
if pkgicu[0] is None:
1351+
if not pkgicu[0]:
13521352
error('''Could not load pkg-config data for "icu-i18n".
13531353
See above errors or the README.md.''')
13541354
(libs, cflags, libpath, icuversion) = pkgicu

0 commit comments

Comments
 (0)