Skip to content

TST: Add azure CI testing to 1.15.x branch. #12083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

charris
Copy link
Member

@charris charris commented Oct 4, 2018

The appveyor webhook is deactivated, so we need to use azure to
test backports on windows before the next 1.15.x release. This
also add testing on the Mac.

The appveyor webhook is deactivated, so we need to use azure to
test backports on windows before the next 1.15.x release. This
also add testing on the Mac.
@charris charris added 05 - Testing 08 - Backport Used to tag backport PRs labels Oct 4, 2018
@charris charris added this to the 1.15.3 release milestone Oct 4, 2018
@charris
Copy link
Member Author

charris commented Oct 4, 2018

This didn't activate azure. I don't see anything in the app that is branch specific, I wonder if we need to put something in the yml file or change something on the pipeline. @chrisrpatterson Thoughts?

@tylerjereddy
Copy link
Contributor

The website settings are definitely on master branch -- not sure if we can easily add more branches for triggering builds without i.e., adding a new pipeline associated with the maintenance branch.

@charris
Copy link
Member Author

charris commented Oct 4, 2018

Maybe the branch needed the yml file when I set up the pipeline. IIRC, the presence of yml files was checked for. At some point I will try deleting and reinstalling the app -- might be a chance to rename the pipeline also.

@charris charris merged commit bc69fcf into numpy:maintenance/1.15.x Oct 4, 2018
@charris charris deleted the add-azure-testing branch October 4, 2018 23:26
@charris
Copy link
Member Author

charris commented Oct 5, 2018

The tests can be run for 1.15.x manually by specifying the commit, but it cannot be done automatically. This seems to be a design fault, as the default branch is set as part of the pipeline, and it seems we can only have one (free) pipeline attached to numpy.

@charris
Copy link
Member Author

charris commented Oct 5, 2018

Solved.

  • Navigate to your project in Azure Pipelines or TFS. Select Pipelines, and then select Builds. Locate your build, and select Edit.
  • Select Triggers. Enable the Pull request validation trigger. Ensure you include the master branch under Branch filters. Add maintenance/1.15.x (will be a pulldown selection).

@charris
Copy link
Member Author

charris commented Oct 5, 2018

I think we can also add triggers to the *.yml file in a trigger section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 - Testing 08 - Backport Used to tag backport PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants