Skip to content

BLD: Make can_link_svml return False for 32bit builds on x86_64 #21896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2022
Merged

BLD: Make can_link_svml return False for 32bit builds on x86_64 #21896

merged 1 commit into from
Jul 3, 2022

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jul 1, 2022 •
edited
Loading

This makes it unnecessary to set NPY_DISABLE_SVML when using a 32-bit Python on x86_64, see #20736.

The test for a 32 bit interpreter follows the approach of https://github.com/pypa/packaging/blob/main/packaging/tags.py#L40

@mkoeppe mkoeppe mentioned this pull request Jul 1, 2022
Closed
charris
charris reviewed Jul 1, 2022
View reviewed changes
@mkoeppe mkoeppe force-pushed the can_link_svml_i386 branch from 0132a53 to 00ec579 Compare July 1, 2022 02:20
@rgommers rgommers added the 36 - Build Build related PR label Jul 3, 2022
rgommers
rgommers approved these changes Jul 3, 2022
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments seem addressed and this LGTM, so in it goes. Thanks @mkoeppe

@rgommers rgommers merged commit f929012 into numpy:main Jul 3, 2022
@rgommers rgommers added this to the 1.24.0 release milestone Jul 3, 2022
@rgommers rgommers added the 09 - Backport-Candidate PRs tagged should be backported label Jul 3, 2022
@mkoeppe mkoeppe deleted the can_link_svml_i386 branch July 3, 2022 16:20
@rgommers rgommers mentioned this pull request Jul 6, 2022
Closed
@charris charris modified the milestones: 1.24.0 release, 1.23.1 release Jul 6, 2022
@charris charris changed the title numpy/core/setup.py (can_link_svml): False for 32bit builds on x86_64 BUG: Make can_link_svml return False for 32bit builds on x86_64 Jul 8, 2022
@charris charris mentioned this pull request Jul 8, 2022
Merged
@charris charris changed the title BUG: Make can_link_svml return False for 32bit builds on x86_64 BLD: Make can_link_svml return False for 32bit builds on x86_64 Jul 8, 2022
@charris charris removed 00 - Bug 09 - Backport-Candidate PRs tagged should be backported labels Jul 8, 2022
@charris charris removed this from the 1.23.1 release milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charris charris charris left review comments

@mattip mattip mattip left review comments

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
36 - Build Build related PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkoeppe @charris @rgommers @mattip