-
Notifications
You must be signed in to change notification settings - Fork 5.9k
8351354: Enhance java -XshowSettings:security:tls to show enabled TLS groups and signature algorithms #24424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… groups and signature algorithms
👋 Welcome back mdonovan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@mpdonova This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@mpdonova This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
/open |
/label security |
@mpdonova This pull request is now open |
@mpdonova |
In this PR I added TLS groups and signature algorithms to the output of the show settings flag. The values are printed in a single column, like the cipher suites. There can be a lot of values so putting on a single line is ugly. I tried putting them in columns, but it is hard to read.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24424/head:pull/24424
$ git checkout pull/24424
Update a local copy of the PR:
$ git checkout pull/24424
$ git pull https://git.openjdk.org/jdk.git pull/24424/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24424
View PR using the GUI difftool:
$ git pr show -t 24424
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24424.diff
Using Webrev
Link to Webrev Comment