Skip to content

8351354: Enhance java -XshowSettings:security:tls to show enabled TLS groups and signature algorithms #24424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mpdonova
Copy link
Contributor

@mpdonova mpdonova commented Apr 3, 2025

In this PR I added TLS groups and signature algorithms to the output of the show settings flag. The values are printed in a single column, like the cipher suites. There can be a lot of values so putting on a single line is ugly. I tried putting them in columns, but it is hard to read.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351354: Enhance java -XshowSettings:security:tls to show enabled TLS groups and signature algorithms (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24424/head:pull/24424
$ git checkout pull/24424

Update a local copy of the PR:
$ git checkout pull/24424
$ git pull https://git.openjdk.org/jdk.git pull/24424/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24424

View PR using the GUI difftool:
$ git pr show -t 24424

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24424.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 3, 2025

👋 Welcome back mdonovan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 3, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 3, 2025
@openjdk
Copy link

openjdk bot commented Apr 3, 2025

@mpdonova The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Apr 3, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented May 1, 2025

@mpdonova This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2025

@mpdonova This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this May 30, 2025
@mpdonova
Copy link
Contributor Author

/open

@mpdonova
Copy link
Contributor Author

/label security

@openjdk openjdk bot reopened this May 30, 2025
@openjdk
Copy link

openjdk bot commented May 30, 2025

@mpdonova This pull request is now open

@openjdk
Copy link

openjdk bot commented May 30, 2025

@mpdonova
The security label was successfully added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant