8354460: Streaming output for attach API should be turned on by default

[alexmenkov]

The fix turns on streaming output for attach operations.
Change in HotSpotVirtualMachine.java sets attach client property.
Change in attachListener.cpp sets server property (used when client does not specify the property in the request - this is the case when attach tool from older release connects to new VM).

Testing: tier1..tier8

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354460: Streaming output for attach API should be turned on by default (Enhancement - P4)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Kevin Walls (@kevinjwalls - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25192/head:pull/25192
$ git checkout pull/25192

Update a local copy of the PR:
$ git checkout pull/25192
$ git pull https://git.openjdk.org/jdk.git pull/25192/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25192

View PR using the GUI difftool:
$ git pr show -t 25192

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25192.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354460: Streaming output for attach API should be turned on by default

Reviewed-by: sspitsyn, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 442 new commits pushed to the master branch:

• e235b61: 8357987: [JVMCI] Add support for retrieving all methods of a ResolvedJavaType
• a44a470: 8358515: make cmp-baseline is broken after JDK-8349665
• cc11b7d: 8356128: Correct documentation for --linux-package-deps
• ... and 439 more: https://git.openjdk.org/jdk/compare/0f2a6c266b2e3aab59a5cd183e10dfc4820ca92d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexmenkov The following labels will be automatically applied to this pull request:

• hotspot-runtime
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (1bda79ad)
• 00: Full (076e6e86)

[alexmenkov]

Ping. Looking for reviewers for the fix.

[sspitsyn]

Looks good.

[kevinjwalls]

thanks Alex.
Apologies for looking at this so late 8-)

[alexmenkov]

Thank for the review @sspitsyn and @kevinjwalls
/integrate

[openjdk]

Going to push as commit da49fa5.
Since your change was applied there have been 443 commits pushed to the master branch:

• 704b599: 8358534: Bailout in Conv2B::Ideal when type of cmp input is not supported
• e235b61: 8357987: [JVMCI] Add support for retrieving all methods of a ResolvedJavaType
• a44a470: 8358515: make cmp-baseline is broken after JDK-8349665
• ... and 440 more: https://git.openjdk.org/jdk/compare/0f2a6c266b2e3aab59a5cd183e10dfc4820ca92d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit da49fa5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.