Skip to content

WIP: Dynamic memtag creation #25322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jdksjolen
Copy link
Contributor

@jdksjolen jdksjolen commented May 20, 2025


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ The pull request body must not be empty.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25322/head:pull/25322
$ git checkout pull/25322

Update a local copy of the PR:
$ git checkout pull/25322
$ git pull https://git.openjdk.org/jdk.git pull/25322/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25322

View PR using the GUI difftool:
$ git pr show -t 25322

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25322.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 20, 2025

👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 20, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented May 20, 2025

@jdksjolen The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@jdksjolen jdksjolen force-pushed the dynamic-memtag-creation-facility-jep branch 12 times, most recently from 3bf3e7c to 7c585ff Compare May 28, 2025 12:13
@openjdk
Copy link

openjdk bot commented May 30, 2025

@jdksjolen this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout dynamic-memtag-creation-facility-jep
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label May 30, 2025
@jdksjolen jdksjolen force-pushed the dynamic-memtag-creation-facility-jep branch 5 times, most recently from bbff12d to a285393 Compare June 2, 2025 09:14
@jdksjolen jdksjolen force-pushed the dynamic-memtag-creation-facility-jep branch 2 times, most recently from 440c5be to b869323 Compare June 2, 2025 11:19
@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Jun 2, 2025
@jdksjolen jdksjolen force-pushed the dynamic-memtag-creation-facility-jep branch from b869323 to da47da7 Compare June 2, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant