-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Speed up max_len_string_array #10024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
looks good. release note in perf section & squash. merge when ready. |
@@ -896,23 +904,32 @@ def clean_index_list(list obj): | |||
|
|||
return maybe_convert_objects(converted), 0 | |||
|
|||
|
|||
ctypedef fused pandas_string: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to mention you could use a better name here :).
my naive quick look does show some improvements to |
@shoyer I didn't have a particular pandas use case for this. I'm going to start using it in some often called paths in odo and I wanted to see if I could squeeze out some more perf. |
I think @jreback had some ideas about using cython memoryviews in some of re csv code similar to how I use them here. IIRC he said there are quite a few places where we don't take full advantage of what cython has to offer. For example if you type a variable as just |
ok squashed. merging on pass |
Before:
After: