added axvlines_color parameter to parallel_coordinates

[undertherain]

parallel_coordinates are in pandas.tools.plotting
'black' color was hard-coded for vertical lines, I suggest to make it an option

[jreback]

@TomAugspurger @sinhrks ?

[TomAugspurger]

No strong opinion here. It's an easy addition but I don't think our parallel coordinate plot is worth expanding.

On Oct 11, 2015, at 10:56, Jeff Reback [email protected] wrote:

@TomAugspurger @sinhrks ?

—
Reply to this email directly or view it on GitHub.

[jreback]

should we deprecate parallel_coordinates ? (is their a direct replacement say in seaborn/mpl/bokeh)? can we simply dispatch?

[TomAugspurger]

No replacement in seaborn / mpl. The best I've seen is here.

[sinhrks]

Though we don't set a high value on maintaining other plotting funcs than .plot method, this kind of small fix looks OK to be applied. Otherwise, may better to deprecate it as unmaintained.

[jreback]

ok can u add a test, make sure the keyworkd are added in the .plot accessor and add a whatsnew note

[undertherain]

Hi guys!
Sorry for the late reply - was traveling a little bit
Thank you for considering my request!

Ehm.... how about passing keyword arguments for avx line potting insted of
just color?
Because well, I needed another color - somebody else might need another
line thickness etc

can make it like this:

def parallel_coordinates(frame, class_column, cols=None, ax=None,
color=None,
use_columns=False, xticks=None, colormap=None,
axvlines=True,
axvlines_kwds={'linewidth':1,'color':'black'}, **kwds):

the default {'linewidth':1,'color':'black'}, ensure that backward
compatibility

Cheers!
Alex

2015-10-19 1:34 GMT+09:00 Jeff Reback [email protected]:

ok can u add a test, make sure the keyworkd are added in the .plot
accessor and add a whatsnew note

—
Reply to this email directly or view it on GitHub
#10709 (comment).

[undertherain]

Oh, right, I already committed this :)
Anyway, just wanted to add the parallel_coordinates is useful in Pandas - at least I did not see any other "out of the box" alternatives

[jreback]

@undertherain ok this is fine. can you squash. ping when done.

[jreback]

actually, pls add a whatnew note (enhancement section), use this PR number as the issue number

[undertherain]

I added the whatsnew note with issue number
but for the "squashing" I can use some hint

[jorisvandenbossche]

@undertherain See here for some explanation: http://pandas-docs.github.io/pandas-docs-travis/contributing.html#combining-commits

[undertherain]

@jorisvandenbossche yep, thank you! I've just got a bit confused as I made few changes, than merged with main version than make few more changes. Anyway, I hope I sorted it out and it should be ready now.

[undertherain]

@jreback oh, in case github doesn''t send notifications to people in the thread not being mentioned explicitly - ping.

[jreback]

merged via 4b6fcc0

thanks!