CLN: remove core/matrix.py, not imported into the pandas namespace #12111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
I don't think this needs to be deprecated in any way. anyone disagree? |
|
I'm +1 on removal. Deprecation warning ought to have been there in 2011 but at this point minimal users will be affected. |
jreback
added a commit
that referenced
this pull request
Jan 21, 2016
CLN: remove core/matrix.py, not imported into the pandas namespace
|
you pushed the button!! =) |
|
oh right is there a way to disable it in GitHub? |
|
No; it's been requested many times by users, though, since in a lot of OSS projects with tighter merge protocol they've had mishaps with merges happening by accident |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.