fix Timedelta.__mul__(NaT) #19819
Merged
fix Timedelta.__mul__(NaT) #19819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19819 +/- ##
=======================================
Coverage 91.61% 91.61%
=======================================
Files 150 150
Lines 48892 48892
=======================================
Hits 44792 44792
Misses 4100 4100
Continue to review full report at Codecov.
|
jreback
requested changes
Feb 22, 2018
| def test_td_mul_nat(self, op, td_nat): | ||
| # GH#19819 | ||
| td = Timedelta(10, unit='d') | ||
| with pytest.raises(TypeError): |
There was a problem hiding this comment.
why do we raise on this again? what is the behavior on divide?
There was a problem hiding this comment.
For the same reason we raise on Timedelta * timedelta (or Timedelta * datetime depending on what hat pd.NaT is wearing).
For division Timedelta / pd.NaT returns np.nan, which is already correct.
jreback
approved these changes
Feb 22, 2018
|
thanks |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff