-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH: Number formatting support for excel styles #22015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Number formatting support for excel styles #22015
Conversation
a1e0788
to
b148a28
Compare
Codecov Report
@@ Coverage Diff @@
## master #22015 +/- ##
==========================================
+ Coverage 92% 92% +<.01%
==========================================
Files 168 168
Lines 50603 50605 +2
==========================================
+ Hits 46555 46557 +2
Misses 4048 4048
Continue to review full report at Codecov.
|
Haven't reviewed code in detail yet but does this reference an existing issue? If not can you open and add reference in whatsnew? |
b3d7650
to
901142c
Compare
Done |
901142c
to
b06cff6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @gfyoung for input.
May just be my lack of familiarity with styling but what is the preferred way of using this from an end user perspective? .apply
with a UDF? Might be worth adding an example to the style notebook to illustrate
@marknsikora : This looks good at the moment. Could you add |
Thanks @marknsikora . |
* ENH: Number formatting support for excel styles
git diff upstream/master -u -- "*.py" | flake8 --diff
Add number formatting support to the excel styles using a fake css entry.
Added new tests, updated docs, and manually verified outputs using both excel output engines that support styling.