Skip to content

CLN: Unused imports in tslibs #26168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 21, 2019
Merged

CLN: Unused imports in tslibs #26168

merged 3 commits into from
Apr 21, 2019

Conversation

mroeschke
Copy link
Member

Removed unused imports in tslibs found via PyCharm.

jbrockmendel
jbrockmendel reviewed Apr 20, 2019
View reviewed changes
pandas/_libs/tslibs/c_timestamp.pyx Outdated
@@ -381,5 +379,5 @@ cdef class _Timestamp(datetime):

def timestamp(self):
"""Return POSIX timestamp as float."""
# py27 compat, see GH#17329
# Note: tz-aware Timestamps will return a UTC-like timestamp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keeping the issue reference would be helpful. It is for naive timestamp that we don’t match the stdlib.

@mroeschke mroeschke added this to the 0.25.0 milestone Apr 21, 2019
@codecov
Copy link

codecov bot commented Apr 21, 2019

Codecov Report

Merging #26168 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26168      +/-   ##
==========================================
- Coverage   91.98%   91.97%   -0.01%     
==========================================
  Files         175      175              
  Lines       52377    52377              
==========================================
- Hits        48180    48176       -4     
- Misses       4197     4201       +4
Flag Coverage Δ
#multiple 90.53% <100%> (ø) ⬆️
#single 40.71% <66.66%> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/tseries/frequencies.py 97.69% <100%> (ø) ⬆️
pandas/core/arrays/datetimes.py 97.79% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc86509...2c5688c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 21, 2019 •
edited
Loading

Codecov Report

Merging #26168 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26168      +/-   ##
==========================================
- Coverage   91.98%   91.97%   -0.01%     
==========================================
  Files         175      175              
  Lines       52377    52377              
==========================================
- Hits        48180    48176       -4     
- Misses       4197     4201       +4
Flag Coverage Δ
#multiple 90.53% <100%> (ø) ⬆️
#single 40.71% <66.66%> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/tseries/frequencies.py 97.69% <100%> (ø) ⬆️
pandas/core/arrays/datetimes.py 97.79% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc86509...2c5688c. Read the comment docs.

@jreback jreback merged commit 966d09e into pandas-dev:master Apr 21, 2019
@jreback
Copy link
Contributor

jreback commented Apr 21, 2019

thanks @mroeschke

@mroeschke mroeschke deleted the tslib_cython_imports branch April 21, 2019 15:50
ryanreh99 pushed a commit to ryanreh99/pandas that referenced this pull request Apr 22, 2019
@mroeschke @ryanreh99
CLN: Unused imports in tslibs (pandas-dev#26168)
bd8b4bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @jreback @jbrockmendel