Skip to content

TST: test_spam_url fails because of Invalid URL #4303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jtratner opened this issue Jul 20, 2013 · 6 comments
Closed

TST: test_spam_url fails because of Invalid URL #4303

jtratner opened this issue Jul 20, 2013 · 6 comments
Labels
IO Data IO issues that don't fit into a more specific label
Milestone

Comments

@jtratner
Copy link
Contributor

Intermittently failing test in travis with data.py with the "unused imports" #4251. @cpcloud any ideas? (failed then passed with the same build)

======================================================================
ERROR: test_spam_url (pandas.io.tests.test_html.TestReadHtmlBase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python2.7_with_system_site_packages/local/lib/python2.7/site-packages/pandas-0.12.0.dev_d61aa5b-py2.7-linux-x86_64.egg/pandas/util/testing.py", line 763, in network_wrapper
    return t(*args, **kwargs)
  File "/home/travis/virtualenv/python2.7_with_system_site_packages/local/lib/python2.7/site-packages/pandas-0.12.0.dev_d61aa5b-py2.7-linux-x86_64.egg/pandas/io/tests/test_html.py", line 131, in test_spam_url
    df1 = self.run_read_html(url, '.*Water.*')
  File "/home/travis/virtualenv/python2.7_with_system_site_packages/local/lib/python2.7/site-packages/pandas-0.12.0.dev_d61aa5b-py2.7-linux-x86_64.egg/pandas/io/tests/test_html.py", line 91, in run_read_html
    return read_html(*args, **kwargs)
  File "/home/travis/virtualenv/python2.7_with_system_site_packages/local/lib/python2.7/site-packages/pandas-0.12.0.dev_d61aa5b-py2.7-linux-x86_64.egg/pandas/io/html.py", line 906, in read_html
    attrs)
  File "/home/travis/virtualenv/python2.7_with_system_site_packages/local/lib/python2.7/site-packages/pandas-0.12.0.dev_d61aa5b-py2.7-linux-x86_64.egg/pandas/io/html.py", line 775, in _parse
    raise retained
ValueError: Invalid URL: "http://ndb.nal.usda.gov/ndb/foods/show/1732?fg=&man=&lfacet=&format=&count=&max=25&offset=&sort=&qlookup=spam"
----------------------------------------------------------------------
@ghost ghost assigned cpcloud Jul 20, 2013
@cpcloud
Copy link
Member

cpcloud commented Jul 20, 2013

i'll pull ur branch down and check it out

@cpcloud
Copy link
Member

cpcloud commented Jul 20, 2013

what's weird is that this is only triggered if urllib2.URLError is caught...

@cpcloud
Copy link
Member

cpcloud commented Jul 20, 2013

also why the heck isn't it skipping? URLError is a subclass of IOError which is caught by the network decorator

@cpcloud
Copy link
Member

cpcloud commented Jul 20, 2013

oh nvm it doesn't skip because i raise a ValueError

@cpcloud
Copy link
Member

cpcloud commented Jul 20, 2013

i'll just remove the try suite there

@cpcloud
Copy link
Member

cpcloud commented Jul 25, 2013

closed by #4305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Data IO issues that don't fit into a more specific label
Projects
None yet
Development

No branches or pull requests

2 participants