Skip to content

Yahoo finance data fails on market cap #5229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jseabold opened this issue Oct 15, 2013 · 4 comments
Closed

Yahoo finance data fails on market cap #5229

jseabold opened this issue Oct 15, 2013 · 4 comments
Labels
Dtype Conversions Unexpected or buggy dtype conversions
Milestone

Comments

@jseabold
Copy link
Contributor

Market cap returns a "B" etc. that needs to be parsed before the result is coerced into a DataFrame.

https://groups.google.com/forum/#!topic/pydata/KOdYtiw7cE8

@jreback
Copy link
Contributor

jreback commented Oct 15, 2013

I actually wouldn't do this, rather just return a non-coercable value as the original value (rather than nan); its tricky to know what fields actually return; leave it up to the user.

@jseabold
Copy link
Contributor Author

Yeah, I agree. I have no idea what this could return. So just change the except part of the float call.

@jreback jreback closed this as completed Jan 3, 2014
@jreback jreback reopened this Jan 3, 2014
@jreback jreback modified the milestones: 0.15.0, 0.14.0 Feb 14, 2014
@gary-dalton
Copy link

I might take a look at this issue. As noted, we don't know what it might possibly return but we do know it returns a "B" that can be parsed properly.

@jreback jreback modified the milestones: 0.15.1, 0.16.0 Nov 6, 2014
davidastephens added a commit to davidastephens/pandas that referenced this issue Nov 7, 2014
@jreback
Copy link
Contributor

jreback commented Nov 7, 2014

closed by #8742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

No branches or pull requests

3 participants