Skip to content

VIS: only apply shared axes handling on actual SubplotAxes #11561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jorisvandenbossche
Copy link
Member

closes #11556
closes #11520

@jorisvandenbossche
Copy link
Member Author

@sinhrks @TomAugspurger What do you think of this approach?

@TomAugspurger
Copy link
Contributor

I think your fix looks fine, but I need to reread those issues to better understand what's going on. It could be a bit before I get to that, so I'm comfortable with merging this if you or @sinhrks are.

@sinhrks
Copy link
Member

sinhrks commented Nov 12, 2015

Looks nice! It's great to add tests of these axes for future cases.

# divider
from mpl_toolkits.axes_grid1 import make_axes_locatable
divider = make_axes_locatable(ax)
cax = divider.append_axes("right", size="5%", pad=0.05)
hasattr(cax, 'is_first_col')
# False

# insert_ax
from mpl_toolkits.axes_grid.inset_locator import inset_axes
iax = inset_axes(ax, width="30%", height=1., loc=3)
hasattr(iax, 'is_first_col')
# False

To fix bugs when dealing with plain Axes objects (GH11556, GH11520)
@jorisvandenbossche
Copy link
Member Author

@sinhrks added those examples to the tests as well

@jreback
Copy link
Contributor

jreback commented Nov 13, 2015

lgtm. merge when ready.

@jreback
Copy link
Contributor

jreback commented Nov 15, 2015

merged via 9ee2139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants