Skip to content

BUG: TDI/PI comparison with zero-dim array #26707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

jbrockmendel
Copy link
Member

The long-term solution to problems of this kind will be #23853.

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #26707 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26707      +/-   ##
==========================================
- Coverage   91.88%   91.88%   -0.01%     
==========================================
  Files         174      174              
  Lines       50699    50702       +3     
==========================================
- Hits        46587    46586       -1     
- Misses       4112     4116       +4
Flag Coverage Δ
#multiple 90.42% <100%> (ø) ⬆️
#single 41.93% <66.66%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/period.py 98.54% <100%> (ø) ⬆️
pandas/core/arrays/timedeltas.py 88.82% <100%> (+0.02%) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b10e31...bab377d. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #26707 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26707      +/-   ##
==========================================
- Coverage   91.88%   91.88%   -0.01%     
==========================================
  Files         174      174              
  Lines       50699    50702       +3     
==========================================
- Hits        46587    46586       -1     
- Misses       4112     4116       +4
Flag Coverage Δ
#multiple 90.42% <100%> (ø) ⬆️
#single 41.93% <66.66%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/period.py 98.54% <100%> (ø) ⬆️
pandas/core/arrays/timedeltas.py 88.82% <100%> (+0.02%) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b10e31...bab377d. Read the comment docs.

@jreback jreback added Bug Period Period data type Timedelta Timedelta data type labels Jun 7, 2019
@jreback jreback added this to the 0.25.0 milestone Jun 7, 2019
@jreback jreback merged commit f51c131 into pandas-dev:master Jun 7, 2019
@jreback
Copy link
Contributor

jreback commented Jun 7, 2019

thanks @jbrockmendel nice to have your PRs again!

@jbrockmendel jbrockmendel deleted the tdcmp branch June 7, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Period Period data type Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparison between TimedeltaIndex/PeriodIndex and 0-dim ndarray raises
2 participants