Misleading warning if session-size > 1MB

[ralfbecker]

Took me a while to debug why code working with old php-memcache failed with php-memcached: Old extension split large sessions into 1MB junks to store in memcached. New one tries to write them to memcached, which fails because memcached does not store anything larger then 1MB, which results in two warnings:

PHP Warning: session_write_close(): error saving session to memcached: SUCCESS
PHP Warning: session_write_close(): Failed to write session data (memcached). Please verify that the current setting of session.save_path is correct (memcached1:11211,memcached2:11211)

Both are not helpful, as they don't explain the real issue.

Maybe giving a more explicit warning like: tried to store session data > 1MB failed (php-memcached does NOT support splitting it in multiple memcached requests)

To get me right: I'm fine with not supporting it, as it does not make much sense to store such big data in the session in the first place.

[sodabrew]

Great suggestion to check for a large session and produce a better error message.

[sodabrew]

The line of code that produces the message is:

php_error_docref(NULL TSRMLS_CC, E_WARNING, "error saving session to memcached: %s", memcached_last_error_message(memc));

The documentation for memcached_last_error_message http://docs.libmemcached.org/libmemcached/memcached_last_error_message.html suggests that a more helpful message would be produced. In fact, producing an error-text of "SUCCESS" when the return value of memcached_set() is not MEMCACHED_SUCCESS doesn't make sense to me.

[sodabrew]

I see no such code in the older memcache extension to split up sessions. Where are you seeing this behavior implemented?

https://git.php.net/?p=pecl/caching/memcache.git;a=blob;f=memcache_session.c;h=6895ab33675c3089d04c16a3eda60d5ca1de2967;hb=HEAD

[ralfbecker]

Hi Aaron, maybe I was wrong, we had that implemented in our own session-handler before we switched to php-memcache builtin one. I thought it was implemented there too ... Needless to say, I can't find in the liked code either. As I said, I don't think splitting up sessions into multiple chunks need to be implemented, just the "error"-message you currently give is best to say misleading, if not totally wrong ;) Ralf Am 16.03.17 um 15:18 schrieb Aaron Stone:

…

I see no such code in the older memcache extension to split up sessions. Where are you seeing this behavior implemented? https://git.php.net/?p=pecl/caching/memcache.git;a=blob;f=memcache_session.c;h=6895ab33675c3089d04c16a3eda60d5ca1de2967;hb=HEAD — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#333 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA7VlBXQWvzp-r-EqnSYSFnDhQ13C_WDks5rmUS3gaJpZM4MNW0N>.

-- Ralf Becker Outdoor Training [www.outdoor-training.de] Geschäftsbereich der EGroupware GmbH Handelsregister HRB Kaiserslautern 3587 Geschäftsführer Birgit und Ralf Becker Leibnizstr. 17, 67663 Kaiserslautern, Germany Telefon +49 (0)631 31657-0

[linusnorton]

I'm receiving this error (error saving session to memcached: SUCCESS) too but it doesn't seem to be session size related. Are there any other possible causes?