Skip to content

Signed integer overflow in ext/calendar/easter.c:94 #16228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
YuanchengJiang opened this issue Oct 5, 2024 · 0 comments
Closed

Signed integer overflow in ext/calendar/easter.c:94 #16228

YuanchengJiang opened this issue Oct 5, 2024 · 0 comments
Assignees
@devnexen
Labels
Bug Extension: calendar Status: Verified

Comments

@YuanchengJiang
Copy link

Description

The following code:

<?php
easter_days(9223372036854775807, 9223372036854775807);

Resulted in this output:

/php-src/ext/calendar/easter.c:94:15: runtime error: signed integer overflow: 9223372036854775807 + 2305843009213693951 cannot be represented in type 'long'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /php-src/ext/calendar/easter.c:94:15

PHP Version

PHP 8.4.0-dev

Operating System

ubuntu 22.04
@devnexen devnexen self-assigned this Oct 5, 2024
devnexen added a commit to devnexen/php-src that referenced this issue Oct 5, 2024
@devnexen
Fix phpGH-16228 overflow on easter_days/easter_date year argument.
b2cea91
@devnexen devnexen linked a pull request Oct 5, 2024 that will close this issue
Fix GH-16228 overflow on easter_days/easter_date year argument. #16241
Closed
devnexen added a commit to devnexen/php-src that referenced this issue Oct 5, 2024
@devnexen
fix build warning for phpGH-16228
1a26e5f
devnexen added a commit to devnexen/php-src that referenced this issue Oct 5, 2024
@devnexen
fix build warning for phpGH-16228
b0a4d4f
devnexen added a commit to devnexen/php-src that referenced this issue Oct 5, 2024
@devnexen
fix build warning for phpGH-16228
5c0f0b5
devnexen added a commit that referenced this issue Oct 5, 2024
@devnexen
fix build warning for GH-16228
6d9903f 
close GH-16250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devnexen devnexen

Labels
Bug Extension: calendar Status: Verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix GH-16228 overflow on easter_days/easter_date year argument. devnexen/php-src
2 participants
@devnexen @YuanchengJiang