-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Drop unnecessary stdint and inttypes header checks #5323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop unnecessary stdint and inttypes header checks #5323
Conversation
Before we do this, I'd like to get rid out our stdint.h / inttypes.h shims for Windows, so we really are using only system headers. @cmb69 Am I understanding right that we no longer need win32/php_stdint.h? It seems that our |
While it still should be possible to build master with VS 2017 and maybe VS 2015, there is certainly no need to support older VS versions, so win32/php_inttypes.h can be removed. Thanks. |
I think https://gist.github.com/cmb69/e517a72a5d86b9982e1a9ad3d10517f7 can be applied on top of this PR (note that I have ignored libmagic.patch). I'm not quite sure about the |
eab07c5
to
e09021c
Compare
https://gist.github.com/cmb69/553a44f5b3f6027fe9c5931cf2b845fe drops several superfluous |
e09021c
to
993ebae
Compare
57da6b2
to
d86c5de
Compare
@cmb69 can we also drop the |
These are not needed for Windows (since the macro is no longer defined), but maybe for other systems? |
I'm trying to read up on it, but it seems Autoconf takes care of defining (at least some of them) when they are not available: https://www.gnu.org/software/autoconf/manual/autoconf-2.60/html_node/Particular-Types.html |
These are always available as of C99. Closes phpGH-5323 Co-authored-by: "Christoph M. Becker" <[email protected]>
d86c5de
to
f91f726
Compare
As they are always available per C99.
Hopefully I didn't forget any checks and the script generating the
libmagic.patch
did it's job.