No NULL check in sqlite connection.c

[wooffie]

Bug report

Bug description:

cpython/Modules/_sqlite/connection.c

Line 960 in 7ec1742

aggregate_instance = (PyObject**)sqlite3_aggregate_context(context, sizeof(PyObject*));

In this case we don'y check it against NULL, and can dereference in next line:

cpython/Modules/_sqlite/connection.c

Line 961 in 7ec1742

if (*aggregate_instance == NULL) {

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

• gh-129346: Handle allocation errors for SQLite aggregate context #129347
• [3.13] gh-129346: Handle allocation errors for SQLite aggregate context (GH-129347) #129372
• [3.12] gh-129346: Handle allocation errors for SQLite aggregate context (GH-129347) #129373

[erlend-aasland]

No, it cannot be NULL. See the SQLite C API docs for more information. We could add an assert.

[erlend-aasland]

Relevant docs:

• https://sqlite.org/c3ref/context.html
• https://sqlite.org/c3ref/aggregate_context.html

[erlend-aasland]

I removed the bug label. This is not a bug; it is just a missing assert.

[erlend-aasland]

Looking more closely at this, I agree with Serhiy it is a bug.