When your templates change, browser caches bust automatically. #16527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me 👍 |
| class_attribute :etag_with_template_digest | ||
| self.etag_with_template_digest = true | ||
|
|
||
| ActiveSupport.on_load :action_view, yield: true do |action_view_base| |
There was a problem hiding this comment.
No need for the block arg?
There was a problem hiding this comment.
Yeah - included it to make it clear that we aren't using the instance_eval form of on_load. We're being called like a normal block.
New default: the template digest is automatically included in your ETags. When you call `fresh_when @post`, the digest for `posts/show.html.erb` is mixed in so future changes to the HTML will blow HTTP caches for you. This makes it easy to HTTP-cache many more of your actions. If you render a different template, you can now pass the `:template` option to include its digest instead: fresh_when @post, template: 'widgets/show' Pass `template: false` to skip the lookup. To turn this off entirely, set: config.action_controller.etag_with_template_digest = false
jeremy
added a commit
that referenced
this pull request
Aug 17, 2014
When your templates change, browser caches bust automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New default: the template digest is automatically included in your ETags.
When you call
fresh_when @post, the digest forposts/show.html.erbis mixed in so future changes to the HTML will blow HTTP caches for you.
This makes it easy to HTTP-cache many more of your actions.
If you render a different template, you can now pass the
:templateoption to include its digest instead:
Pass
template: falseto skip the lookup. To turn this off entirely, set: