Skip to content

Pub/Sub on RESP3 #3388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2023
Merged

Pub/Sub on RESP3 #3388

merged 1 commit into from
May 2, 2023

Conversation

sazzad16
Copy link
Contributor

@sazzad16 sazzad16 commented May 1, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 69.90% and project coverage change: +0.80 🎉

Comparison is base (e6341ad) 66.42% compared to head (9369068) 67.22%.

❗ Current head 9369068 differs from pull request most recent head 783ad4b. Consider uploading reports for the commit 783ad4b to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##                5.0    #3388      +/-   ##
============================================
+ Coverage     66.42%   67.22%   +0.80%     
- Complexity     4723     4766      +43     
============================================
  Files           270      270              
  Lines         15436    15459      +23     
  Branches        997     1004       +7     
============================================
+ Hits          10253    10392     +139     
+ Misses         4748     4626     -122     
- Partials        435      441       +6     
Impacted Files Coverage Δ
src/main/java/redis/clients/jedis/JedisPubSub.java 67.50% <62.96%> (+14.77%) ⬆️
src/main/java/redis/clients/jedis/Protocol.java 88.00% <66.66%> (-0.38%) ⬇️
...in/java/redis/clients/jedis/BinaryJedisPubSub.java 82.97% <77.27%> (+82.97%) ⬆️
src/main/java/redis/clients/jedis/Connection.java 81.77% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sazzad16 sazzad16 merged commit 024e066 into redis:5.0 May 2, 2023
@sazzad16 sazzad16 deleted the resp-pubsub branch May 2, 2023 12:05
@sazzad16 sazzad16 added this to the 5.0.0 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants