Skip to content

[2.0] add RediSearch_CreateDocument2 with Spec (#2212) #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

ashtul
Copy link
Contributor

@ashtul ashtul commented Aug 26, 2021

(cherry picked from commit f0f0044)

@ashtul ashtul requested review from rafie and oshadmi August 26, 2021 07:14
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #2218 (f0f0044) into 2.0 (1ce4ef6) will increase coverage by 0.04%.
The diff coverage is 88.15%.

❗ Current head f0f0044 differs from pull request most recent head 580db2c. Consider uploading reports for the commit 580db2c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              2.0    #2218      +/-   ##
==========================================
+ Coverage   80.20%   80.24%   +0.04%     
==========================================
  Files         146      151       +5     
  Lines       21091    22239    +1148     
==========================================
+ Hits        16915    17846     +931     
- Misses       4176     4393     +217     
Impacted Files Coverage Δ
src/aggregate/aggregate_plan.c 35.57% <0.00%> (ø)
src/aggregate/aggregate_plan.h 100.00% <ø> (ø)
src/dictionary.c 90.40% <ø> (-3.72%) ⬇️
src/doc_table.c 61.56% <ø> (-0.16%) ⬇️
src/doc_table.h 100.00% <ø> (ø)
src/doc_types.h 100.00% <ø> (ø)
src/document.c 73.12% <ø> (-1.64%) ⬇️
src/document_add.c 87.20% <ø> (ø)
src/document_basic.c 82.78% <ø> (+4.72%) ⬆️
src/ext/default.c 88.53% <ø> (+0.39%) ⬆️
... and 112 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ce4ef6...580db2c. Read the comment docs.

@ashtul ashtul merged commit 10d2728 into 2.0 Aug 26, 2021
@ashtul ashtul deleted the cp-2.0-llapi-CreateDoc2 branch August 26, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants