disallow aggregations in maps #1671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b4da16 to
a4878f0
Compare
jeffreylovitz
added a commit
that referenced
this pull request
Apr 27, 2021
* disalow aggregations in maps * Add documentation, expand on error message * Skip invalidated TCK tests Co-authored-by: Jeffrey Lovitz <[email protected]> (cherry picked from commit e86b5e3)
swilly22
added a commit
that referenced
this pull request
Apr 28, 2021
* Shortest path func (#1627) * WIP * add BFS to destination algorithm * WIP * Add shortestPath function call * Revert changes around OpShortestPath * Add test cases * One-time creation of matrices for shortestPath * formatting * Address PR comments * Add documentation * Update commands.md * search for path object only under specific clauses * Update LAGraph_bfs_pushpull.h * Address PR comments * Don't cache schema IDs in shortestPath Co-authored-by: swilly22 <[email protected]> Co-authored-by: Roi Lipman <[email protected]> (cherry picked from commit 98aa629) * Fix: Updated benchmark readme with newest specifications ( and simplification also ). Updated benchmark automation wrapper version. (#1633) (cherry picked from commit 03543c0) * add Julia client (#1636) (cherry picked from commit 484faa7) * Julia client (#1637) * add Julia client * update client list (cherry picked from commit 5388836) * Fix label retrieval on cached unknown value (#1644) (cherry picked from commit 4fa2c1b) * GRAPH.LIST lists all graph keys in keyspace (no support for cluster env) (#1649) * list graphs in keyspace * test graph.list * add graph.list to commands doc (cherry picked from commit bc33380) * add sqrt function (#1653) (cherry picked from commit 2de9fcf) * Sqrt (#1655) * add sqrt function * switch to std:isnan (cherry picked from commit 1f056a2) * Fix memory leak on allocated keys in OpAggregate (#1650) * Fix memory leak on allocated keys in OpAggregate * Address PR comments * Address PR comments Co-authored-by: Roi Lipman <[email protected]> (cherry picked from commit 096373d) * drain thread pools before shutting down (#1656) * drain thread pools before shutting down * pause worker threads on shutdown * skip thread pools clean up on server shutdown (cherry picked from commit 1782e83) * Support filtering on variable-length edges in traversals (#1657) * Support filtering on variable-length edges in traversals * concatenate multiple variable edge filters into a single filter tree * Address PR comments * add path object to clone record Co-authored-by: swilly22 <[email protected]> Co-authored-by: Roi Lipman <[email protected]> (cherry picked from commit 9204660) * The default warnings.warn prints itself, this function should override the default behavior (#1662) Co-authored-by: Ofir Moskovich <[email protected]> (cherry picked from commit d9a50ed) * Limit threadpool queue size (#1664) * limit number of pending queries * init config as part of testing * free thread safe ctx only for blocked clients * test max pending query limit * Add documentation * Address PR comments * Attempt to fix test on CI * Resolve memory leak * wrong thread count Co-authored-by: Jeffrey Lovitz <[email protected]> (cherry picked from commit 2b88d39) * Fix CI benchmarks on version tag (#1665) (cherry picked from commit 93d87ac) * Add benchmark to validate variable-length edge filters (#1667) (cherry picked from commit e8b5e94) * Apply path filters after all other filters (#1668) * Apply path filters after all other filters * switch to a single query construction * Use dedicated relocate function * Update execution_plan_construct.c Co-authored-by: swilly22 <[email protected]> Co-authored-by: Roi Lipman <[email protected]> (cherry picked from commit e084bb6) * Runtime index utilisation (#1641) * WIP migrate search query composition from utilize_indices to a utility file * [WIP] runtime index query construction * resolve compile-time unknowns * entity functions are reduceable if the entity is known * test index runtime query construction * normalize filter, make sure filtered entity is on the left hand side * free index scan filter tree * return none converted filters * WIP * WIP * index none indexed field names * pull from index until unresolved filter pass or iterator deplete * test index scan over none indexable values * remove include of deleted file * rebase conflicts resolved * address PR comments * change index separator (cherry picked from commit 247d747) * disallow aggregations in maps (#1671) * disalow aggregations in maps * Add documentation, expand on error message * Skip invalidated TCK tests Co-authored-by: Jeffrey Lovitz <[email protected]> (cherry picked from commit e86b5e3) Co-authored-by: filipe oliveira <[email protected]> Co-authored-by: Roi Lipman <[email protected]> Co-authored-by: OfirMos <[email protected]>
pnxguide
pushed a commit
to CMU-SPEED/RedisGraph
that referenced
this pull request
Mar 22, 2023
* disalow aggregations in maps * Add documentation, expand on error message * Skip invalidated TCK tests Co-authored-by: Jeffrey Lovitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force user to specify aggregations within a separated WITH clause, this way determining which expressions take part in group key is clear to both user and RedisGraph.
RETURN a, {b:x, c:count(n)}, dWill emit an error, instructing user to rewrite as:
WITH key0, ..., count(n) AS c RETURN key0,... {b:x, c:c}