-
Notifications
You must be signed in to change notification settings - Fork 357
Update to Svelte 3 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
you beauty — merged via #17 |
This was referenced Jul 26, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the realworld app to Svelte 3 and the latest Sapper beta.
Aside from the upgrade there were a few problems with the application as it was, so I've fixed these and added a few features too:
/profile/@username
./profile/
now takes you to your own profile page if you are logged in or to the home page if you are not.Follow ${username}
button on the profile page now redirects to the login page if you aren't logged in.example.com/2
- maybe this needs a prefix? (Better pagination #3 )Everything was relatively straight forward, the only thing I wasn't too sure about was reimplementing the custom store from v2. Since this is an example app, I wanted to use the session store, so I essentially created a set of custom methods that could be applied to any store and passed a reference to the session store to it (in the root
_layout.svelte
). I wanted to keep the easyimport { store } from '@sapper/app'
but I also wnated those custom methods. Maybe there is a better way.There was no
package-lock.json
in the old version, there is now.This PR fixes, closes or kind of fixes or closes the following issues: #3, #4, #9, #14, #15.