Skip to content

Mandatory authorizer field breaks Lambdas without authorizer #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hugoflug opened this issue Mar 2, 2021 · 3 comments
Closed

Mandatory authorizer field breaks Lambdas without authorizer #101

hugoflug opened this issue Mar 2, 2021 · 3 comments

Comments

@hugoflug
Copy link

hugoflug commented Mar 2, 2021

In 8f0698f, the authorizer field was added to ApiGatewayRequestContext.
However, Lambdas doesn't always have an authorizer. We have a use case where we want to do the auth-checking inside the lambda itself, and because of this change we can't use this library.

Would it be OK to open a PR to make this field a Maybe?
@NickSeagull
Copy link
Contributor

I guess that it wouldn't be any problem, although maybe @dnikolovv could have more context than me for this

@dnikolovv
Copy link
Contributor

I think a Maybe would work great! Sorry for the breakage :(

@hugoflug hugoflug mentioned this issue Mar 3, 2021
Merged
@NickSeagull
Copy link
Contributor

Closed with #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hugoflug @NickSeagull @dnikolovv