fix: disable importHelpers to drop tslib dependency
#13
Conversation
🦋 Changeset detectedLatest commit: 63fdb78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis update disables the TypeScript Changes
Assessment against linked issues
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR disables the importHelpers option to drop the tslib dependency while updating several dependency versions.
- Updated dependency versions in package.json for @eslint-react/eslint-plugin, npm-run-all2, and react-router-dom.
- Added a changeset file (.changeset/proud-carpets-shine.md) documenting the patch fix.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated dependency versions to support disabling importHelpers and dropping tslib |
| .changeset/proud-carpets-shine.md | Added changeset metadata documenting the fix |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 53 53
Branches 16 16
=========================================
Hits 53 53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 63fdb78 in 45 seconds. Click for details.
- Reviewed
39lines of code in2files - Skipped
2files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .changeset/proud-carpets-shine.md:1
- Draft comment:
Commit message mentions disabling importHelpers to drop tslib dependency, but no tsconfig change is shown in the diff. Confirm the tsconfig update is included elsewhere. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to confirm if a change is included elsewhere, which violates the rule against asking for confirmation or double-checking things. It does not provide a specific code suggestion or point out a specific issue with the code.
2. package.json:65
- Draft comment:
Bump of @eslint-react/eslint-plugin from ^1.49.0 to ^1.50.0. Verify that this update is compatible with the project. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. package.json:83
- Draft comment:
Updated npm-run-all2 from ^8.0.3 to ^8.0.4. Ensure no unintended side effects in scripts. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
4. package.json:88
- Draft comment:
react-router-dom updated from ^7.6.0 to ^7.6.1. Confirm that this change is intended. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_UelLRn36t1sErJ1B
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
size-limit report 📦
|
|
Deploy preview for eslint-import-context ready! ✅ Preview Built with commit 63fdb78. |
commit: |
📊 Package size report 4%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tsconfig.json (1)
4-5: Consider bundle size implications of disabling importHelpers.Setting
"importHelpers": falsewill inline TypeScript helper functions across your compiled files, potentially increasing total bundle size. Ensure this trade-off is acceptable or introduce a bundler plugin to dedupe common helpers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (3)
.changeset/proud-carpets-shine.md(1 hunks)package.json(2 hunks)tsconfig.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (13)
- GitHub Check: Lint and Test with Node.js 24 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 on macos-latest
- GitHub Check: Lint and Test with Node.js 24 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 20 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 20 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 on windows-latest
- GitHub Check: Lint and Test with Node.js 18 on macos-latest
- GitHub Check: Lint and Test with Node.js 20 on macos-latest
- GitHub Check: Lint and Test with Node.js 18 on windows-latest
- GitHub Check: Lint and Test with Node.js 18 on ubuntu-latest
- GitHub Check: Package Size Report
- GitHub Check: Lint and Test with Node.js 22 on windows-latest
🔇 Additional comments (5)
.changeset/proud-carpets-shine.md (2)
1-3: Changeset header matches the expected format.The YAML frontmatter correctly specifies the package name, level, and separators.
5-5: Changeset description clearly documents the fix.The summary “fix: disable
importHelpersto droptslibdependency” succinctly explains the change.package.json (3)
65-65: Verify @eslint-react/eslint-plugin version bump.You’ve updated to
^1.50.0; please confirm there are no new linting rules or breaking changes.
83-83: Approve npm-run-all2 patch bump.The update from
^8.0.3to^8.0.4is a patch-level bump and appears safe.
88-88: Verify react-router-dom version bump.Minor bump to
^7.6.1—please check for any API adjustments or deprecations in the changelog.
close import-js/eslint-import-resolver-typescript#456
Important
Disable
importHelpersto removetslibdependency and update several dependencies inpackage.json.importHelpersto removetslibdependency.@eslint-react/eslint-pluginto^1.50.0inpackage.json.npm-run-all2to^8.0.4inpackage.json.react-router-domto^7.6.1inpackage.json.This description was created by
for 63fdb78. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit