BREAKING CHANGE: Change topLevelOrigin to topOrigin #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romandev
approved these changes
May 7, 2018
There was a problem hiding this comment.
lgtm
I made a patch in Chromium as well.
https://chromium-review.googlesource.com/c/chromium/src/+/1045705
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 7, 2018
The related spec was changed: w3c/payment-handler#301 Bug: 840041 Change-Id: Ic76fffe0b974210edc3888378ded197d06e035b7
|
🎵🎶don’t forget to do the checklist at the top of the pull request. If you love a speciation, it should have tests! 🎸 All together now! 🎹 (That’s quite a catchy tune) |
|
Hi @marcoscaceres, Whoops; sorry about that. Let me see if we have tests already (to be modified). |
|
@marcoscaceres and @romandev, I did not write a new test, however. |
|
Thanks! I don’t think new tests are needed, so we should be good. |
|
Added link to WPT. |
|
Just noting for future reference, when we rename IDL, that's generally labelled a "BREAKING CHANGE" (I know, all caps... but not as scary as it seems, specially early on!) - but it's important to note that we made a change that will impact real code (either browser or user-land), and definitely not "editorial". |
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 9, 2018
The related spec was changed: w3c/payment-handler#301 Bug: 840041 Change-Id: Ic76fffe0b974210edc3888378ded197d06e035b7
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 11, 2018
The related spec was changed: w3c/payment-handler#301 Bug: 840041 Change-Id: Ic76fffe0b974210edc3888378ded197d06e035b7 Reviewed-on: https://chromium-review.googlesource.com/1045705 Reviewed-by: Mathieu Perreault <[email protected]> Reviewed-by: Ganggui Tang <[email protected]> Reviewed-by: Kinuko Yasuda <[email protected]> Commit-Queue: Jinho Bang <[email protected]> Cr-Commit-Position: refs/heads/master@{#557757}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 18, 2018
… topOrigin, a=testonly Automatic update from web-platform-testsPaymentHandler: Change topLevelOrigin to topOrigin (#10872) The related spec was changed: w3c/payment-handler#301 Bug: 840041 Change-Id: Ic76fffe0b974210edc3888378ded197d06e035b7 -- wpt-commits: da28291ff0b1b6ee6a36004e8deef9c2f098935d wpt-pr: 10872
sole
pushed a commit
to sole/gecko
that referenced
this pull request
May 21, 2018
… topOrigin, a=testonly Automatic update from web-platform-testsPaymentHandler: Change topLevelOrigin to topOrigin (#10872) The related spec was changed: w3c/payment-handler#301 Bug: 840041 Change-Id: Ic76fffe0b974210edc3888378ded197d06e035b7 -- wpt-commits: da28291ff0b1b6ee6a36004e8deef9c2f098935d wpt-pr: 10872
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
… topOrigin, a=testonly Automatic update from web-platform-testsPaymentHandler: Change topLevelOrigin to topOrigin (#10872) The related spec was changed: w3c/payment-handler#301 Bug: 840041 Change-Id: Ic76fffe0b974210edc3888378ded197d06e035b7 -- wpt-commits: da28291ff0b1b6ee6a36004e8deef9c2f098935d wpt-pr: 10872 UltraBlame original commit: a1d15e1d860e18e3e70400bb807cd889d41b7439
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
… topOrigin, a=testonly Automatic update from web-platform-testsPaymentHandler: Change topLevelOrigin to topOrigin (#10872) The related spec was changed: w3c/payment-handler#301 Bug: 840041 Change-Id: Ic76fffe0b974210edc3888378ded197d06e035b7 -- wpt-commits: da28291ff0b1b6ee6a36004e8deef9c2f098935d wpt-pr: 10872 UltraBlame original commit: a1d15e1d860e18e3e70400bb807cd889d41b7439
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
… topOrigin, a=testonly Automatic update from web-platform-testsPaymentHandler: Change topLevelOrigin to topOrigin (#10872) The related spec was changed: w3c/payment-handler#301 Bug: 840041 Change-Id: Ic76fffe0b974210edc3888378ded197d06e035b7 -- wpt-commits: da28291ff0b1b6ee6a36004e8deef9c2f098935d wpt-pr: 10872 UltraBlame original commit: a1d15e1d860e18e3e70400bb807cd889d41b7439
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #259
The following tasks have been completed:
Implementation commitment:
Preview | Diff