Skip to content

TypeError unless all or none of encodings have rids #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Sep 26, 2022

Fixes #2734.


Preview | Diff

@jan-ivar jan-ivar self-assigned this Sep 26, 2022
@dontcallmedom
Copy link
Member

webrtc.js needs to be updated to list infra in the xref property of respecConfig to have map/contain be recognized

@jan-ivar
Copy link
Member Author

webrtc.js needs to be updated to list infra in the xref property of respecConfig to have map/contain be recognized

Yes this PR and #2775 depend on #2772 which adds this. Since we ran out of time today to merge the latter, I'll reshuffle the PRs to avoid this dependency.

@dontcallmedom dontcallmedom added the Simulcast Issue relating to Simulcast label Oct 12, 2022
@jan-ivar
Copy link
Member Author

Error: Pull request 2774 not labeled as editorial and not referenced in amendments.json

Ok, so this is new. I need to rebase and add something to this file I assume? cc @dontcallmedom

@jan-ivar jan-ivar merged commit 828c191 into w3c:main Oct 13, 2022
@dontcallmedom
Copy link
Member

thanks @jan-ivar for integrating the changes in amendments.json - indeed, the CI error is a recent addition to make sure we don't lose track of this.
FWIW, I had to tweak a bit the change you made, since the id referenced in amendments.json needs to be for an element that contains the changes (you had picked the <dt> when the changes were in the <dd>); I'll try to see how to make it easier to review these amendment descriptions.

@jan-ivar jan-ivar deleted the ridsornothing branch October 13, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editors can integrate Needs Test Needs a WPT test Simulcast Issue relating to Simulcast
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addTransceiver does not check for missing rid properties
3 participants