Prevent GC of non-closed RTCDataChannels #2902
Conversation
|
Test forthcoming in https://phabricator.services.mozilla.com/D190744. |
| ], | ||
| "closing-procedure": [ | ||
| { | ||
| "description": "Prevent GC of non-closed RTCDataChannels", |
There was a problem hiding this comment.
Given where we're removing the channel I'm not sure we're preventing GC of non-closing channels?
webrtc.html
Outdated
| </li> | ||
| <li> | ||
| <p> | ||
| Remove <var>channel</var> from <var>connection</var>.{{RTCPeerConnection/[[DataChannels]]}}. |
There was a problem hiding this comment.
It seems good to do it there so that calling close() will remove synchronously the dc from the set.
What about the case of a transport that gets errored?
Shouldn't we also do the same in https://w3c.github.io/webrtc-pc/#announcing-a-data-channel-as-closed?
There was a problem hiding this comment.
Hmm, that "procedure" is also an algorithm called from https://w3c.github.io/webrtc-pc/#data-transport-closing-procedure
There's also this note suggesting the closing procedure is called from somewhere other than close() but it's not.
Fixes #2624.
Preview | Diff